[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Fix I2C bus 1 timing for Grunt.
Justin TerAvest (Code Review)
gerrit at coreboot.org
Fri Jan 26 23:21:10 CET 2018
Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/23459
Change subject: mb/google/kahlee: Fix I2C bus 1 timing for Grunt.
......................................................................
mb/google/kahlee: Fix I2C bus 1 timing for Grunt.
I measured the rise and fall times for I2C bus 1 from userspace
manually. This commit fixes the values there to reflect reality.
BUG=b:72442912,b:70232394
Change-Id: I4f593cb2674006060cad9a77753c23f7d9828c9b
Signed-off-by: Justin TerAvest <teravest at chromium.org>
---
M src/mainboard/google/kahlee/variants/grunt/devicetree.cb
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/23459/1
diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index 977e32d..6d14d14 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -28,11 +28,10 @@
.fall_time_ns = 52,
}"
- # TODO(teravest): Fix speeds here.
register "i2c[1]" = "{
.speed = I2C_SPEED_FAST,
- .rise_time_ns = 104,
- .fall_time_ns = 52,
+ .rise_time_ns = 84,
+ .fall_time_ns = 4,
}"
# TODO(teravest): Fix speeds here.
--
To view, visit https://review.coreboot.org/23459
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f593cb2674006060cad9a77753c23f7d9828c9b
Gerrit-Change-Number: 23459
Gerrit-PatchSet: 1
Gerrit-Owner: Justin TerAvest <teravest at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180126/0b31532a/attachment.html>
More information about the coreboot-gerrit
mailing list