[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Move SmmLock to end of POST
Martin Roth (Code Review)
gerrit at coreboot.org
Fri Jan 26 21:58:30 CET 2018
Martin Roth has posted comments on this change. ( https://review.coreboot.org/23437 )
Change subject: amd/stoneyridge: Move SmmLock to end of POST
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/23437/2/src/soc/amd/stoneyridge/finalize.c
File src/soc/amd/stoneyridge/finalize.c:
https://review.coreboot.org/#/c/23437/2/src/soc/amd/stoneyridge/finalize.c@40
PS2, Line 40: BIOS_DEBUG
should this be higher than debug? BIOS_WARNING maybe?
printk(BIOS_WARNING, "ERROR: Failed to finalize all cores\n");
--
To view, visit https://review.coreboot.org/23437
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b7e33e7045d397e41f571caff6a2acbb64eaab
Gerrit-Change-Number: 23437
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 26 Jan 2018 20:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180126/0a6d2b06/attachment.html>
More information about the coreboot-gerrit
mailing list