[coreboot-gerrit] Change in coreboot[master]: mb/intel/glkrvp: Set S0ix lazy wake mask

Shamile Khan (Code Review) gerrit at coreboot.org
Fri Jan 26 18:46:51 CET 2018


Shamile Khan has uploaded this change for review. ( https://review.coreboot.org/23453


Change subject: mb/intel/glkrvp: Set S0ix lazy wake mask
......................................................................

mb/intel/glkrvp: Set S0ix lazy wake mask

Enable S0ix wake mask programming from coreboot using unified host event
programming interface.

BRANCH=none
BUG=none
TEST=Verify masks with ec hostevent command on S0, S3, S5 and S0ix. Also
check that lidclose/lidopen command from EC console wakes system up from
S3 or S0ix.

Change-Id: I60343aaa9e0ddfd38d42b6d0aa2820e2fd880fb7
Signed-off-by: Shamile Khan <shamile.khan at intel.com>
---
M src/mainboard/intel/glkrvp/ec.c
M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/ec.h
2 files changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/23453/1

diff --git a/src/mainboard/intel/glkrvp/ec.c b/src/mainboard/intel/glkrvp/ec.c
index c6632cd..09344a0 100644
--- a/src/mainboard/intel/glkrvp/ec.c
+++ b/src/mainboard/intel/glkrvp/ec.c
@@ -29,6 +29,7 @@
 		.sci_events = MAINBOARD_EC_SCI_EVENTS,
 		.s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,
 		.s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,
+		.s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS,
 	};
 
 	printk(BIOS_ERR, "mainboard: EC init\n");
diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/ec.h b/src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/ec.h
index 8b22c8e..d31d35a 100644
--- a/src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/ec.h
@@ -47,6 +47,8 @@
 	(MAINBOARD_EC_S5_WAKE_EVENTS |\
 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED))
 
+#define MAINBOARD_EC_S0IX_WAKE_EVENTS	(MAINBOARD_EC_S3_WAKE_EVENTS)
+
 /* Log EC wake events plus EC shutdown events */
 #define MAINBOARD_EC_LOG_EVENTS \
 	(EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_SHUTDOWN) |\

-- 
To view, visit https://review.coreboot.org/23453
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60343aaa9e0ddfd38d42b6d0aa2820e2fd880fb7
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 1
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180126/bdd9d835/attachment.html>


More information about the coreboot-gerrit mailing list