[coreboot-gerrit] Change in coreboot[master]: intel/sandybridge: Tear down CAR in a separate postcar stage

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23450 )

Change subject: intel/sandybridge: Tear down CAR in a separate postcar stage
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/23450/3/src/cpu/intel/car/romstage.c
File src/cpu/intel/car/romstage.c:

https://review.coreboot.org/#/c/23450/3/src/cpu/intel/car/romstage.c@59
PS3, Line 59: setup_stack_and_mtrrs();
should we simply keep this and load postcar in this function and return garbage to make it complile?



-- 
To view, visit https://review.coreboot.org/23450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieefe0564af3470cba484eea131802f1529dbe22c
Gerrit-Change-Number: 23450
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 26 Jan 2018 16:45:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180126/66b1c5ca/attachment.html>