[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee/variants/kahlee/gpio.c: Fix I2C3

[Richard Spiegel (Code Review)]

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/23451


Change subject: mb/google/kahlee/variants/kahlee/gpio.c: Fix I2C3
......................................................................

mb/google/kahlee/variants/kahlee/gpio.c: Fix I2C3

GPIO pins 19 and 20 are by default I2C3 and were wrongly being converted
to AGPIO. Luckily, AGESA at AmdInitEnv was reverting them back to I2C3.
As there are discussions on removing GPIO code from AGESA, this needs to
be fixed before this change ever happens.

BUG=b:72483553
TEST=none

Change-Id: I49c80f1944b090b30cdf3da509209922279ae4ed
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/mainboard/google/kahlee/variants/kahlee/gpio.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/23451/1

diff --git a/src/mainboard/google/kahlee/variants/kahlee/gpio.c b/src/mainboard/google/kahlee/variants/kahlee/gpio.c
index e357c7e..4ebb9f8 100644
--- a/src/mainboard/google/kahlee/variants/kahlee/gpio.c
+++ b/src/mainboard/google/kahlee/variants/kahlee/gpio.c
@@ -39,10 +39,14 @@
 	{GPIO_15, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },
 
 	/* APU_I2C_3_SCL */
-	{GPIO_19, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },
+	/* I2C is default for pin19
+	* {GPIO_19, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },
+	*/
 
 	/* APU_I2C_3_SDA */
-	{GPIO_20, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },
+	/* I2C is default for pin20
+	* {GPIO_20, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },
+	*/
 
 	/* AGPIO22 EC_SCI */
 	{GPIO_22, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },

-- 
To view, visit https://review.coreboot.org/23451
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49c80f1944b090b30cdf3da509209922279ae4ed
Gerrit-Change-Number: 23451
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180126/d0ff646f/attachment.html>