[coreboot-gerrit] Change in coreboot[master]: intel: Prepare registers so Windows drivers are happier

[Patrick Georgi (Code Review)]

Hello Pratikkumar V Prajapati,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23431

to review the following change.


Change subject: intel: Prepare registers so Windows drivers are happier
......................................................................

intel: Prepare registers so Windows drivers are happier

Change-Id: I12ebed30de4df9814ccb62341c7715fc62c7f5b9
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati at intel.com>
---
M src/drivers/intel/gma/opregion.c
M src/soc/intel/apollolake/graphics.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/common/opregion.c
M src/soc/intel/skylake/graphics.c
5 files changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/23431/1

diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c
index b6d4e07..74c629c 100644
--- a/src/drivers/intel/gma/opregion.c
+++ b/src/drivers/intel/gma/opregion.c
@@ -285,6 +285,7 @@
 	opregion->header.mailboxes = MAILBOXES_MOBILE;
 
 	// TODO Initialize Mailbox 1
+	opregion->mailbox1.clid = 1;
 
 	// TODO Initialize Mailbox 3
 	opregion->mailbox3.bclp = IGD_BACKLIGHT_BRIGHTNESS;
diff --git a/src/soc/intel/apollolake/graphics.c b/src/soc/intel/apollolake/graphics.c
index 4fa525e..55b9861 100644
--- a/src/soc/intel/apollolake/graphics.c
+++ b/src/soc/intel/apollolake/graphics.c
@@ -42,6 +42,8 @@
 
 	current += sizeof(igd_opregion_t);
 
+	opregion->mailbox1.clid = 1;
+
 	/* TODO Initialize Mailbox 3 */
 	opregion->mailbox3.bclp = IGD_BACKLIGHT_BRIGHTNESS;
 	opregion->mailbox3.pfit = IGD_FIELD_VALID | IGD_PFIT_STRETCH;
diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c
index ada2741..61ae203 100644
--- a/src/soc/intel/braswell/acpi.c
+++ b/src/soc/intel/braswell/acpi.c
@@ -480,6 +480,7 @@
 	struct device *igd;
 
 	/* TODO Initialize Mailbox 1 */
+	opregion->mailbox1.clid = 1;
 
 	/* TODO Initialize Mailbox 3 */
 	opregion->mailbox3.bclp = IGD_BACKLIGHT_BRIGHTNESS;
diff --git a/src/soc/intel/common/opregion.c b/src/soc/intel/common/opregion.c
index b8111a0..f35e12a 100644
--- a/src/soc/intel/common/opregion.c
+++ b/src/soc/intel/common/opregion.c
@@ -58,7 +58,7 @@
 
 	/* 8KiB */
 	opregion->header.size = sizeof(igd_opregion_t) / KiB;
-	opregion->header.version = IGD_OPREGION_VERSION;
+	opregion->header.version = IGD_OPREGION_VERSION << 24;
 
 	/* FIXME We just assume we're mobile for now */
 	opregion->header.mailboxes = MAILBOXES_MOBILE;
diff --git a/src/soc/intel/skylake/graphics.c b/src/soc/intel/skylake/graphics.c
index 8e6d6ec..f39f39c 100644
--- a/src/soc/intel/skylake/graphics.c
+++ b/src/soc/intel/skylake/graphics.c
@@ -67,6 +67,8 @@
 {
 	u16 reg16;
 
+	opregion->mailbox1.clid = 1;
+
 	/* Initialize Mailbox 3 */
 	opregion->mailbox3.bclp = IGD_BACKLIGHT_BRIGHTNESS;
 	opregion->mailbox3.pfit = IGD_FIELD_VALID | IGD_PFIT_STRETCH;

-- 
To view, visit https://review.coreboot.org/23431
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12ebed30de4df9814ccb62341c7715fc62c7f5b9
Gerrit-Change-Number: 23431
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180125/36df0d45/attachment-0001.html>