[coreboot-gerrit] Change in coreboot[master]: ectool: Add an option to get and use EC ports from /proc/ioports

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/23430 )

Change subject: ectool: Add an option to get and use EC ports from /proc/ioports
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/23430/3/util/ectool/ec.c
File util/ectool/ec.c:

https://review.coreboot.org/#/c/23430/3/util/ectool/ec.c@175
PS3, Line 175: ioports
/proc/ioports is only found on linux, not OSX/BSD(/Windows?). Perhaps an if-guard is appropriate.



-- 
To view, visit https://review.coreboot.org/23430
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3005f5cd6e37206ef187267b0542efdeb26b3af
Gerrit-Change-Number: 23430
Gerrit-PatchSet: 3
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 25 Jan 2018 15:51:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180125/4ffbfb93/attachment.html>