[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Use TSEG for SMM

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23419 )

Change subject: nb/intel/gm45: Use TSEG for SMM
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/23419/4/src/cpu/intel/model_6fx/model_6fx_init.c
File src/cpu/intel/model_6fx/model_6fx_init.c:

https://review.coreboot.org/#/c/23419/4/src/cpu/intel/model_6fx/model_6fx_init.c@170
PS4, Line 170: int cpu_get_apic_id_map(int *apic_id_map)
Redefining obviously doesn't work when multiple CPU models are selected. Any tips on where to put this?

The idea is to get parallel mp init going, so this will go away when that is implemented.



-- 
To view, visit https://review.coreboot.org/23419
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic80c65ea42fcf554ea5695772e8828d2f3b00b98
Gerrit-Change-Number: 23419
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 25 Jan 2018 01:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180125/5c159831/attachment.html>