[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Update camera power enable GPIOs

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Jan 24 22:19:56 CET 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23414


Change subject: mb/google/poppy/variants/nautilus: Update camera power enable GPIOs
......................................................................

mb/google/poppy/variants/nautilus: Update camera power enable GPIOs

This change updates the camera power enable GPIOs as per the latest
schematics.

BUG=b:68964831

Change-Id: I5d9126ed8ca2b714f6276f4d3a24c243d7654774
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/nautilus/gpio.c
M src/mainboard/google/poppy/variants/nautilus/include/variant/gpio.h
2 files changed, 7 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/23414/1

diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c
index 2a76fd1..fea9da3 100644
--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c
+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c
@@ -127,13 +127,13 @@
 	PAD_CFG_GPI(GPP_C6, 20K_PU, DEEP),
 	/* C7  : SM1DATA ==> NC */
 	PAD_CFG_NC(GPP_C7),
-	/* C8  : UART0_RXD ==> NC */
-	PAD_CFG_NC(GPP_C8),
+	/* C8  : UART0_RXD ==> CHP3_P3.3V_DX_WFCAM_EN */
+	PAD_CFG_GPO(GPP_C8, 0, DEEP),
 	/* C9  : UART0_TXD ==> CHP3_P3.3V_DX_DIG_EN */
 	PAD_CFG_GPO(GPP_C9, 0, DEEP),
 	/* C10 : UART0_RTS# ==> CHP3_CAM_PMIC_RST_L */
 	PAD_CFG_GPO(GPP_C10, 1, DEEP),
-	/* C11 : UART0_CTS# ==> CHP3_P3.3V_DX_CAM_EN */
+	/* C11 : UART0_CTS# ==> CHP3_P3.3V_DX_UFCAM_EN */
 	PAD_CFG_GPO(GPP_C11, 1, DEEP),
 	/* C12 : UART1_RXD ==> PCH_MEM_CONFIG[0] */
 	PAD_CFG_GPI(GPP_C12, NONE, DEEP),
diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/gpio.h b/src/mainboard/google/poppy/variants/nautilus/include/variant/gpio.h
index 4f79495..7482e74 100644
--- a/src/mainboard/google/poppy/variants/nautilus/include/variant/gpio.h
+++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/gpio.h
@@ -18,4 +18,8 @@
 
 #include <baseboard/gpio.h>
 
+/* Nautilus differs from baseboard in the GPIO used for EN_PP3300_DX_CAM. */
+#undef EN_PP3300_DX_CAM
+#define EN_PP3300_DX_CAM	GPP_C8
+
 #endif /* __MAINBOARD_GPIO_H__ */

-- 
To view, visit https://review.coreboot.org/23414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d9126ed8ca2b714f6276f4d3a24c243d7654774
Gerrit-Change-Number: 23414
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180124/222969ef/attachment.html>


More information about the coreboot-gerrit mailing list