[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Re-configure GPP_{C8, C9} in ramstage

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Jan 24 22:19:57 CET 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23415


Change subject: mb/google/poppy/variants/nautilus: Re-configure GPP_{C8,C9} in ramstage
......................................................................

mb/google/poppy/variants/nautilus: Re-configure GPP_{C8,C9} in ramstage

UART0 GPIOs are put back into native mode during FSP-S stage. This is
because UART0 is PCI 1e.0 and it needs to be kept enabled so that
other functions 1e.x can be enumerated properly.

This change uses the late gpio configuration API to re-configure UART0
pins as GPIOs after FSP-S is run.

BUG=b:68964831

Change-Id: Ie54f2783afb3bfe5c2ab92c85e20375fbe0f3f5c
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/nautilus/gpio.c
1 file changed, 14 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/23415/1

diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c
index fea9da3..a064d26 100644
--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c
+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c
@@ -371,6 +371,14 @@
 	PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST),
 };
 
+/* Late pad configuration in ramstage */
+static const struct pad_config late_gpio_table[] = {
+	/* C8  : UART0_RXD ==> CHP3_P3.3V_DX_WFCAM_EN */
+	PAD_CFG_GPO(GPP_C8, 0, DEEP),
+	/* C9  : UART0_TXD ==> CHP3_P3.3V_DX_DIG_EN */
+	PAD_CFG_GPO(GPP_C9, 0, DEEP),
+};
+
 const struct pad_config *variant_gpio_table(size_t *num)
 {
 	*num = ARRAY_SIZE(gpio_table);
@@ -382,3 +390,9 @@
 	*num = ARRAY_SIZE(early_gpio_table);
 	return early_gpio_table;
 }
+
+const struct pad_config *variant_late_gpio_table(size_t *num)
+{
+	*num = ARRAY_SIZE(late_gpio_table);
+	return late_gpio_table;
+}

-- 
To view, visit https://review.coreboot.org/23415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie54f2783afb3bfe5c2ab92c85e20375fbe0f3f5c
Gerrit-Change-Number: 23415
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180124/8ac8ff74/attachment.html>


More information about the coreboot-gerrit mailing list