[coreboot-gerrit] Change in coreboot[master]: payloads/tianocore: Add a patch to use the proper BytesPerscanline

Idwer Vollering (Code Review) gerrit at coreboot.org
Wed Jan 24 13:18:33 CET 2018


Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/23403 )

Change subject: payloads/tianocore: Add a patch to use the proper BytesPerscanline
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/23403/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23403/1//COMMIT_MSG@12
PS1, Line 12: Tested on Thinkpad X220 with libgfxinit on 1366x768 displaz.
'displaz'


https://review.coreboot.org/#/c/23403/1/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch
File payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch:

https://review.coreboot.org/#/c/23403/1/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch@28
PS1, Line 28:  																						
Without having read the original file (FbGop.c): is there a good reason for using this amount of indenting?



-- 
To view, visit https://review.coreboot.org/23403
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9eaf692f86d416cd4ec3cc73a8b0aa0a28a38dd
Gerrit-Change-Number: 23403
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Comment-Date: Wed, 24 Jan 2018 12:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180124/3d5f1eb6/attachment.html>


More information about the coreboot-gerrit mailing list