[coreboot-gerrit] Change in coreboot[master]: smbios: handle DIMM of 32G or more
Patrick Rudolph (Code Review)
gerrit at coreboot.org
Tue Jan 23 16:52:32 CET 2018
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/23396 )
Change subject: smbios: handle DIMM of 32G or more
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23396/1/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/23396/1/src/arch/x86/smbios.c@214
PS1, Line 214: t->extended_size = dimm->dimm_size;
Please make sure that bit 31 is always zero, as written in the spec.
--
To view, visit https://review.coreboot.org/23396
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc559454c16ccd685aaaed0d60f1af69b634ea2e
Gerrit-Change-Number: 23396
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert at online.net>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 23 Jan 2018 15:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180123/b1690126/attachment.html>
More information about the coreboot-gerrit
mailing list