[coreboot-gerrit] Change in coreboot[master]: mainboard/google/zoombini/variant/meowth: add memory options

Nick Vaccaro (Code Review) gerrit at coreboot.org
Tue Jan 23 13:31:14 CET 2018


Hello Nick Vaccaro,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23388

to review the following change.


Change subject: mainboard/google/zoombini/variant/meowth: add memory options
......................................................................

mainboard/google/zoombini/variant/meowth: add memory options

Add support for new memory stuffing options.

Strap Setting - Associated SPD File
----------------------------------------
0b000 - Samsung_K4F8E304HB_1GB.spd.hex
0b001 - Hynix_H9HCNNN8KUMLHR_1GB.spd.hex
0b010 - Samsung_K4F6E3S4HM_2GB.spd.hex
0b011 - Hynix_H9HCNNNCPUMLHR_4GB.spd.hex

BUG=b:69011806
BRANCH=none
TEST=none

Change-Id: Ia2ac564541b57647c3b605ce3389d74251490ca0
Signed-off-by: Nick Vaccaro <nvaccaro at chromium.org>
---
A src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNBPUMLHR_2GB.spd.hex
M src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex
M src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F6E3S4HM_2GB.spd.hex
3 files changed, 35 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/23388/1

diff --git a/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNBPUMLHR_2GB.spd.hex b/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNBPUMLHR_2GB.spd.hex
new file mode 100644
index 0000000..87d0420
--- /dev/null
+++ b/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNBPUMLHR_2GB.spd.hex
@@ -0,0 +1,32 @@
+23 11 10 OE 15 19 95 08 00 40 00 00 0A 63 00 00
+09 00 04 00 D2 5D 05 00 89 41 90 A8 90 A0 05 D0
+02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 FB 00 23 17 9B
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 80 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex b/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex
index 98e7cbd..d02c276 100644
--- a/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex
+++ b/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex
@@ -1,5 +1,5 @@
-23 11 10 OE 17 21 B5 08 00 40 00 00 0A 12 00 00
-51 00 05 FF D2 5D 01 00 A0 41 90 A8 90 A0 05 D0
+23 11 10 OE 17 21 95 08 00 40 00 00 0A 21 00 00
+48 00 05 FF D2 5D 01 00 A0 41 90 A8 90 A0 05 D0
 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F6E3S4HM_2GB.spd.hex b/src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F6E3S4HM_2GB.spd.hex
index 7e9a0cf..83cb098 100644
--- a/src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F6E3S4HM_2GB.spd.hex
+++ b/src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F6E3S4HM_2GB.spd.hex
@@ -1,5 +1,5 @@
 23 11 10 OE 15 21 95 08 00 40 00 00 0A 21 00 00
-09 00 04 00 D2 5D 05 00 89 41 90 A8 90 A0 05 D0
+48 00 04 00 D2 5D 05 00 89 41 90 A8 90 A0 05 D0
 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

-- 
To view, visit https://review.coreboot.org/23388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2ac564541b57647c3b605ce3389d74251490ca0
Gerrit-Change-Number: 23388
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180123/170c50ca/attachment-0001.html>


More information about the coreboot-gerrit mailing list