[coreboot-gerrit] Change in coreboot[master]: mainboard/google/zoombini/variant/meowth: add PCH_WP_OD

[Nick Vaccaro (Code Review)]

Hello Nick Vaccaro,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23389

to review the following change.


Change subject: mainboard/google/zoombini/variant/meowth: add PCH_WP_OD
......................................................................

mainboard/google/zoombini/variant/meowth: add PCH_WP_OD

Configure GPP_H12 as an input for PCH_WP_OD.

BUG=b:72202352
BRANCH=none
TEST=none

Change-Id: Ie5b60644a24d745add4d0d38c1421974b8a0017b
Signed-off-by: Nick Vaccaro <nvaccaro at chromium.org>
---
M src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h
M src/mainboard/google/zoombini/variants/meowth/gpio.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/23389/1

diff --git a/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h
index e1b566d..c1417d6 100644
--- a/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h
+++ b/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h
@@ -29,7 +29,7 @@
 #define GPIO_EC_IN_RW		GPP_A8
 
 /* BIOS Flash Write Protect */
-#define GPIO_PCH_WP		GPP_A1
+#define GPIO_PCH_WP		GPP_H12
 
 /* EC wake is LAN_WAKE# which is a special DeepSX wake pin */
 #define GPE_EC_WAKE		GPP_74
diff --git a/src/mainboard/google/zoombini/variants/meowth/gpio.c b/src/mainboard/google/zoombini/variants/meowth/gpio.c
index f4ae9b8..a299d9c 100644
--- a/src/mainboard/google/zoombini/variants/meowth/gpio.c
+++ b/src/mainboard/google/zoombini/variants/meowth/gpio.c
@@ -225,7 +225,7 @@
 				   NF1), /* PCH_RCAM_SAR0_I2C5_SDA */
 /* I2C5_SCL */		PAD_CFG_NF(GPP_H11, NONE, DEEP,
 				   NF1), /* PCH_RCAM_SAR0_I2C5_SCL */
-/* M2_SKT2_CFG0 */	PAD_NC(GPP_H12, NONE),
+/* M2_SKT2_CFG0 */	PAD_CFG_GPI(GPP_H12, NONE, DEEP), /* PCH_WP_OD */
 /* M2_SKT2_CFG1 */	PAD_NC(GPP_H13, NONE),
 /* M2_SKT2_CFG2 */	PAD_NC(GPP_H14, NONE),
 /* M2_SKT2_CFG3 */	PAD_NC(GPP_H15, NONE),

-- 
To view, visit https://review.coreboot.org/23389
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5b60644a24d745add4d0d38c1421974b8a0017b
Gerrit-Change-Number: 23389
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180123/b196d0a5/attachment-0001.html>