[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Enable elan touchpad wakeup system fro...

Van Chen (Code Review) gerrit at coreboot.org
Tue Jan 23 02:28:28 CET 2018


Van Chen has uploaded this change for review. ( https://review.coreboot.org/23363


Change subject: mb/google/poppy/variants/nami: Enable elan touchpad wakeup system from S3
......................................................................

mb/google/poppy/variants/nami: Enable elan touchpad wakeup system from S3

BUG=b:71839089
TEST=
1. emerge-nami coreboot chromeos-bootimage
2. powerd_dbus_suspend
3. touch touchpad to wakeup system
4. localhost ~ # cat /var/log/eventlog.txt
  | 2018-01-21 17:01:59 | S0ix Enter
  | 2018-01-21 17:02:04 | S0ix Exit
  | 2018-01-21 17:02:04 | Wake Source | GPIO | 80

Change-Id: Ie550cfa3f7b5fd105f89c16076d428743392d0e4
Signed-off-by: van_chen <van_chen at compal.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nami/devicetree.cb
M src/mainboard/google/poppy/variants/nami/gpio.c
2 files changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/23363/1

diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb
index 0ea39fe..73cb8c3 100644
--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb
@@ -255,6 +255,7 @@
 				register "hid" = ""ELAN0000""
 				register "desc" = ""ELAN Touchpad""
 				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E3_IRQ)"
+				register "wake" = "GPE0_DW2_16"
 				device i2c 15 on end
 			end
 		end # I2C #1
diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index 999f1de..dbee643 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -241,8 +241,8 @@
 	PAD_CFG_NF(GPP_E14, 20K_PD, DEEP, NF1),
 	/* E15 : DDPD_HPD2 ==> NC */
 	PAD_CFG_NC(GPP_E15),
-	/* E16 : DDPE_HPD3 ==> NC(TP17) */
-	PAD_CFG_NC(GPP_E16),
+        /* E16 : DDPE_HPD3 ==> PCH_GPP_E16 */
+        PAD_CFG_GPI_ACPI_SCI(GPP_E16, NONE, DEEP, INVERT),
 	/* E17 : EDP_HPD ==> EDP_HPD */
 	PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1),
 	/* E18 : DDPB_CTRLCLK ==> SOC_DP1_CTRL_CLK */

-- 
To view, visit https://review.coreboot.org/23363
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie550cfa3f7b5fd105f89c16076d428743392d0e4
Gerrit-Change-Number: 23363
Gerrit-PatchSet: 1
Gerrit-Owner: Van Chen <van_chen at compal.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180123/f939e353/attachment.html>


More information about the coreboot-gerrit mailing list