[coreboot-gerrit] Change in coreboot[master]: libpayload: Add console driver qemu debugcon

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23306 )

Change subject: libpayload: Add console driver qemu debugcon
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/23306/1/payloads/libpayload/Kconfig
File payloads/libpayload/Kconfig:

https://review.coreboot.org/#/c/23306/1/payloads/libpayload/Kconfig@325
PS1, Line 325: 	bool "QEMU debugcon console driver"
Looks like this uses inb()/outb() so it needs a depends on ARCH_X86


https://review.coreboot.org/#/c/23306/1/payloads/libpayload/Kconfig@326
PS1, Line 326: 	default y
Does it really make sense to enable this by default for all builds? (If you really need to do that, please add a 'default n if CHROMEOS' above it.)



-- 
To view, visit https://review.coreboot.org/23306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieba9ed38642cb0833564304dda2a317071f2b25c
Gerrit-Change-Number: 23306
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 22 Jan 2018 21:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180122/cbe12257/attachment.html>