[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Add AC/DC loadline settings

[Gaggery Tsai (Code Review)]

Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/23349


Change subject: mb/google/fizz: Add AC/DC loadline settings
......................................................................

mb/google/fizz: Add AC/DC loadline settings

This patch adds AC and DC loadline settings since vr_config_enable is
set. Without correct AD/DC loadline settings, VRs reported incorrect
VID values which caused CPU freqency clipping. The clipping reason
could be retrieved from MSR 0x64F. From VRTT report, the AC/DC
loadline resistences are within spec, we can use default value defined
in Table 6-1, doc #543977.

BUG=b:70646304
BRANCH=None
TEST=emerge-fizz coreboot chromeos-bootimage & Read AC/DC loadline
     settings from DCI to ensure the values were programmed correctly.

Change-Id: Id0ce29fa5726ca3711aa4c822fb123e2de7bc48f
Signed-off-by: Gaggery Tsai <gaggery.tsai at intel.com>
---
M src/mainboard/google/fizz/devicetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/23349/1

diff --git a/src/mainboard/google/fizz/devicetree.cb b/src/mainboard/google/fizz/devicetree.cb
index 0af7603..4930fbe 100644
--- a/src/mainboard/google/fizz/devicetree.cb
+++ b/src/mainboard/google/fizz/devicetree.cb
@@ -128,6 +128,8 @@
 		.imon_offset = 0x0,
 		.icc_max = VR_CFG_AMP(7),
 		.voltage_limit = 1520,
+		.ac_loadline = 1030,
+		.dc_loadline = 1030,
 	}"
 
 	register "domain_vr_config[VR_IA_CORE]" = "{
@@ -141,6 +143,8 @@
 		.imon_offset = 0x0,
 		.icc_max = VR_CFG_AMP(34),
 		.voltage_limit = 1520,
+		.ac_loadline = 240,
+		.dc_loadline = 240,
 	}"
 
 	register "domain_vr_config[VR_GT_UNSLICED]" = "{
@@ -154,6 +158,8 @@
 		.imon_offset = 0x0,
 		.icc_max = VR_CFG_AMP(35),
 		.voltage_limit = 1520,
+		.ac_loadline = 310,
+		.dc_loadline = 310,
 	}"
 
 	register "domain_vr_config[VR_GT_SLICED]" = "{
@@ -167,6 +173,8 @@
 		.imon_offset = 0x0,
 		.icc_max = VR_CFG_AMP(35),
 		.voltage_limit = 1520,
+		.ac_loadline = 310,
+		.dc_loadline = 310,
 	}"
 
 	# Enable Root port 3(x1) for LAN.

-- 
To view, visit https://review.coreboot.org/23349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0ce29fa5726ca3711aa4c822fb123e2de7bc48f
Gerrit-Change-Number: 23349
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180122/0f2242b3/attachment.html>