[coreboot-gerrit] Change in coreboot[master]: payloads/external/GRUB2: add veyron support

[Marty Plummer (Code Review)]

Hello Marty E. Plummer,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23342

to review the following change.


Change subject: payloads/external/GRUB2: add veyron support
......................................................................

payloads/external/GRUB2: add veyron support

Add a check for veyron devices (as far as I can tell all veyron devices
are rockchip rk3288-based). This may be renamed in the future or
extended to support non-veyron rk3288 boards.

Change-Id: I5f01e2f3360e2bb317b8300d32cbaae97193e259
Signed-off-by: Marty E. Plummer <hanetzer at startmail.com>
---
M payloads/external/GRUB2/Makefile
M payloads/external/Makefile.inc
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/23342/1

diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile
index 2f65cee..a22151a 100644
--- a/payloads/external/GRUB2/Makefile
+++ b/payloads/external/GRUB2/Makefile
@@ -36,6 +36,9 @@
 ifeq ($(CONFIG_VENDOR_EMULATION),y)
 IMAGE_FORMAT=arm-coreboot-vexpress
 endif
+ifeq ($(CONFIG_SOC_ROCKCHIP_RK3288),y)
+IMAGE_FORMAT=arm-coreboot-veyron
+endif
 endif
 
 grub2/build/config.h: $(CONFIG_DEP) | checkout
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc
index 232f37a..5868e8f 100644
--- a/payloads/external/Makefile.inc
+++ b/payloads/external/Makefile.inc
@@ -176,6 +176,7 @@
 			CONFIG_GRUB2_REVISION=$(CONFIG_GRUB2_REVISION) \
 			CONFIG_GRUB2_REVISION_ID=$(CONFIG_GRUB2_REVISION_ID) \
 			CONFIG_GRUB2_EXTRA_MODULES=$(CONFIG_GRUB2_EXTRA_MODULES) \
+			CONFIG_SOC_ROCKCHIP_RK3288=$(CONFIG_SOC_ROCKCHIP_RK3288) \
 			CONFIG_VENDOR_EMULATION=$(CONFIG_VENDOR_EMULATION)
 
 payloads/external/GRUB2/grub2/build/default_payload.elf: grub2

-- 
To view, visit https://review.coreboot.org/23342
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f01e2f3360e2bb317b8300d32cbaae97193e259
Gerrit-Change-Number: 23342
Gerrit-PatchSet: 1
Gerrit-Owner: Marty Plummer <hanetzer at protonmail.com>
Gerrit-Reviewer: Marty E. Plummer <hanetzer at startmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180120/1267dc12/attachment-0001.html>