[coreboot-gerrit] Change in coreboot[master]: payloads/external/GRUB2: add support for vexpress

Marty Plummer (Code Review) gerrit at coreboot.org
Sat Jan 20 22:15:41 CET 2018


Hello Marty E. Plummer,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23341

to review the following change.


Change subject: payloads/external/GRUB2: add support for vexpress
......................................................................

payloads/external/GRUB2: add support for vexpress

Tested on qemu-system-arm, and may work on actual vexpress hardware, but
I do not have anything to test on myself.

Change-Id: Id62e7397807ff51ebfb7cd4f3210457f2b3e3666
Signed-off-by: Marty E. Plummer <hanetzer at startmail.com>
---
M payloads/external/GRUB2/Makefile
M payloads/external/Makefile.inc
2 files changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/23341/1

diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile
index 7d4745f..2f65cee 100644
--- a/payloads/external/GRUB2/Makefile
+++ b/payloads/external/GRUB2/Makefile
@@ -33,6 +33,9 @@
 ifeq ($(CONFIG_ARCH_ARM),y)
 DTB=--dtb=
 ARCH_TRIPLE=arm-eabi
+ifeq ($(CONFIG_VENDOR_EMULATION),y)
+IMAGE_FORMAT=arm-coreboot-vexpress
+endif
 endif
 
 grub2/build/config.h: $(CONFIG_DEP) | checkout
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc
index ff2bd65..232f37a 100644
--- a/payloads/external/Makefile.inc
+++ b/payloads/external/Makefile.inc
@@ -175,7 +175,8 @@
 			CONFIG_GRUB2_MASTER=$(CONFIG_GRUB2_MASTER) \
 			CONFIG_GRUB2_REVISION=$(CONFIG_GRUB2_REVISION) \
 			CONFIG_GRUB2_REVISION_ID=$(CONFIG_GRUB2_REVISION_ID) \
-			CONFIG_GRUB2_EXTRA_MODULES=$(CONFIG_GRUB2_EXTRA_MODULES)
+			CONFIG_GRUB2_EXTRA_MODULES=$(CONFIG_GRUB2_EXTRA_MODULES) \
+			CONFIG_VENDOR_EMULATION=$(CONFIG_VENDOR_EMULATION)
 
 payloads/external/GRUB2/grub2/build/default_payload.elf: grub2
 

-- 
To view, visit https://review.coreboot.org/23341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id62e7397807ff51ebfb7cd4f3210457f2b3e3666
Gerrit-Change-Number: 23341
Gerrit-PatchSet: 1
Gerrit-Owner: Marty Plummer <hanetzer at protonmail.com>
Gerrit-Reviewer: Marty E. Plummer <hanetzer at startmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180120/3b3e5c2c/attachment.html>


More information about the coreboot-gerrit mailing list