[coreboot-gerrit] Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable PCH_FP_PWR_EN

Vincent Palatin (Code Review) gerrit at coreboot.org
Fri Jan 19 11:25:11 CET 2018


Vincent Palatin has uploaded this change for review. ( https://review.coreboot.org/23329


Change subject: mainboard/google/zoombini/variants/meowth: enable PCH_FP_PWR_EN
......................................................................

mainboard/google/zoombini/variants/meowth: enable PCH_FP_PWR_EN

Turn on the load switch to the FP MCU at startup, so the kernel can
detect it and use it.
The load switch enable pin is connected to the GPP_A11 PCH pin (aka
PCH_FP_PWR_EN).

Signed-off-by: Vincent Palatin <vpalatin at chromium.org>

BRANCH=none
BUG=b:71986991
TEST=on Meowth, see the kernel detecting a cros_fp device at startup:
[    2.133456] cros-ec-spi spi-PRP0001:00: Fingerprint MCU detected.
[    2.157420] cros-ec-spi spi-PRP0001:00: Chrome EC device registered

Change-Id: Id3c40b965a5f018c63481c2e2eea3fc8307352bd
---
M src/mainboard/google/zoombini/variants/meowth/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/23329/1

diff --git a/src/mainboard/google/zoombini/variants/meowth/gpio.c b/src/mainboard/google/zoombini/variants/meowth/gpio.c
index f4ae9b8..790567f 100644
--- a/src/mainboard/google/zoombini/variants/meowth/gpio.c
+++ b/src/mainboard/google/zoombini/variants/meowth/gpio.c
@@ -29,7 +29,7 @@
 /* CLKRUN# */		PAD_CFG_GPI(GPP_A8, NONE, DEEP), /* EC_IN_RW_OD */
 /* ESPI_CLK */		PAD_CFG_NF(GPP_A9, NONE, DEEP, NF2), /* ESPI_CLK_R */
 /* CLKOUT_LPC1 */	PAD_NC(GPP_A10, NONE),
-/* PME# */		PAD_CFG_GPO(GPP_A11, 0, DEEP), /* PCH_FP_PWR_EN */
+/* PME# */		PAD_CFG_GPO(GPP_A11, 1, DEEP), /* PCH_FP_PWR_EN */
 /* BM_BUSY# */		PAD_CFG_GPI(GPP_A12, NONE, DEEP), /* FPMCU_INT */
 /* SUSWARN# */		PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1), /* SUSWARN_L */
 /* ESPI_RESET# */	PAD_CFG_NF(GPP_A14, NONE, DEEP, NF2), /* ESPI_RESET_L */

-- 
To view, visit https://review.coreboot.org/23329
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3c40b965a5f018c63481c2e2eea3fc8307352bd
Gerrit-Change-Number: 23329
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Palatin <vpalatin at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180119/33e278d3/attachment.html>


More information about the coreboot-gerrit mailing list