[coreboot-gerrit] Change in coreboot[master]: mainboard/asus/am1i-a: remove unwanted variable
Gergely Kiss (Code Review)
gerrit at coreboot.org
Thu Jan 18 21:44:30 CET 2018
Gergely Kiss has uploaded this change for review. ( https://review.coreboot.org/23320
Change subject: mainboard/asus/am1i-a: remove unwanted variable
......................................................................
mainboard/asus/am1i-a: remove unwanted variable
The variable t32 was originally used to make bitwise operations,
but it is not required anymore. Also, it was assigned twice accidentally,
which has introduced a new Coverity Scan defect.
Change-Id: I77afd5064304a36991f63cf1328e13820144efb6
Signed-off-by: Gergely Kiss <mail.gery at gmail.com>
---
M src/mainboard/asus/am1i-a/romstage.c
1 file changed, 3 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/23320/1
diff --git a/src/mainboard/asus/am1i-a/romstage.c b/src/mainboard/asus/am1i-a/romstage.c
index d62052f..c7cd93e 100644
--- a/src/mainboard/asus/am1i-a/romstage.c
+++ b/src/mainboard/asus/am1i-a/romstage.c
@@ -116,7 +116,7 @@
void board_BeforeAgesa(struct sysinfo *cb)
{
int i;
- u32 t32, val;
+ u32 val;
u8 byte;
pci_devfn_t dev;
u32 *addr32;
@@ -145,15 +145,11 @@
/* Configure ClkDrvStr1 settings */
addr32 = (u32 *)0xfed80e24;
- t32 = *addr32;
- t32 = 0x030800aa;
- *addr32 = t32;
+ *addr32 = 0x030800aa;
/* Configure MiscClkCntl1 settings */
addr32 = (u32 *)0xfed80e40;
- t32 = *addr32;
- t32 = 0x000c4050;
- *addr32 = t32;
+ *addr32 = 0x000c4050;
/* enable SIO LPC decode */
dev = PCI_DEV(0, 0x14, 3);
--
To view, visit https://review.coreboot.org/23320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77afd5064304a36991f63cf1328e13820144efb6
Gerrit-Change-Number: 23320
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Kiss <mail.gery at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180118/49371689/attachment.html>
More information about the coreboot-gerrit
mailing list