[coreboot-gerrit] Change in coreboot[master]: security/tpm: Set up generic TSPI

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22106 )

Change subject: security/tpm: Set up generic TSPI
......................................................................


Patch Set 36:

(6 comments)

https://review.coreboot.org/#/c/22106/36/src/security/tpm/tspi/tspi.c
File src/security/tpm/tspi/tspi.c:

https://review.coreboot.org/#/c/22106/36/src/security/tpm/tspi/tspi.c@26
PS36, Line 26:  * SetupTPM starts the TPM and establishes the root of trust for the
> where does SetupTPM come from, do you mean tpm_setup ?
Done


https://review.coreboot.org/#/c/22106/36/src/security/tpm/tspi/tspi.c@30
PS36, Line 30:  * to reboot in recovery mode in all cases.  The recovery mode calls SetupTPM
> I don't see how recovery mode is entered, there's just a hard_reset();. […]
In terms of security yes this should be the default case if CONFIG_TPM_INIT_FAILURE_IS_FATAL is enabled.


https://review.coreboot.org/#/c/22106/36/src/security/tpm/tspi/tspi.c@84
PS36, Line 84: 					"TPM: Can't enable physical presence command.\n");
> wrong indentation
Done


https://review.coreboot.org/#/c/22106/36/src/security/tpm/tspi/tspi.c@91
PS36, Line 91: 						 "TPM: Can't assert physical presence.\n");
> wrong indentation
Done


https://review.coreboot.org/#/c/22106/36/src/security/tpm/tspi/tspi.c@105
PS36, Line 105: 					 "TPM: disabled (%d) or deactivated (%d). Fixing...\n",
> wrong indentation
Done


https://review.coreboot.org/#/c/22106/36/src/security/tpm/tspi/tspi.c@127
PS36, Line 127: 
> move printk(BIOS_INFO, "TPM: setup succeeded\n"); to this point, that on error it's not printed at a […]
Done



-- 
To view, visit https://review.coreboot.org/22106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb
Gerrit-Change-Number: 22106
Gerrit-PatchSet: 36
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Randall Spangler <randall at spanglers.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 18 Jan 2018 16:03:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180118/96a0622a/attachment.html>