[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add child CARD device into eMMC/SD controller

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/23314


Change subject: soc/intel/cannonlake: Add child CARD device into eMMC/SD controller
......................................................................

soc/intel/cannonlake: Add child CARD device into eMMC/SD controller

For the internal eMMC to be used by non-chrome for installation,
the CARD device and _RMV methods are required.  Without these,
other OSes does not show the eMMC as a valid installation target.

TEST= boot CNL-RVP with Tiano payload and install Windows 10
to the internal eMMC drive.

Change-Id: Icfdccd88bc113d97c2fabf4c63d8d772737a6057
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/cannonlake/acpi/scs.asl
1 file changed, 20 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/23314/1

diff --git a/src/soc/intel/cannonlake/acpi/scs.asl b/src/soc/intel/cannonlake/acpi/scs.asl
index 27f082c..1e37d1b 100644
--- a/src/soc/intel/cannonlake/acpi/scs.asl
+++ b/src/soc/intel/cannonlake/acpi/scs.asl
@@ -17,6 +17,7 @@
 	/* EMMC */
 	Device(PEMC) {
 		Name(_ADR, 0x001A0000)
+		Name (_DDN, "eMMC Controller")
 		Name (TEMP, 0)
 
 		OperationRegion(SCSR, PCI_Config, 0x00, 0x100)
@@ -45,12 +46,22 @@
 			Or (PMCR, 0x0003, PMCR)
 			Store (PMCR, ^TEMP)
 		}
+
+		Device (CARD)
+		{
+			Name (_ADR, 0x00000008)
+			Method (_RMV, 0, NotSerialized)
+			{
+				Return (0)
+			}
+		}
 	}
 
 	/* SD CARD */
 	Device (SDXC)
 	{
 		Name (_ADR, 0x00140005)
+		Name (_DDN, "SD Controller")
 		Name (TEMP, 0)
 
 		OperationRegion (SDPC, PCI_Config, 0x00, 0x100)
@@ -80,5 +91,14 @@
 			Or (PMCR, 0x0003, PMCR)
 			Store (PMCR, ^TEMP)
 		}
+
+		Device (CARD)
+		{
+			Name (_ADR, 0x00000008)
+			Method (_RMV, 0, NotSerialized)
+			{
+				Return (1)
+			}
+		}
 	} /* Device (SDXC) */
 }

-- 
To view, visit https://review.coreboot.org/23314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfdccd88bc113d97c2fabf4c63d8d772737a6057
Gerrit-Change-Number: 23314
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180118/99a3caab/attachment.html>