[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/block/pi: Fix AGESA heap deallocator

Marc Jones (Code Review) gerrit at coreboot.org
Tue Jan 16 02:59:39 CET 2018


Marc Jones has uploaded a new patch set (#2). ( https://review.coreboot.org/23284 )

Change subject: soc/amd/common/block/pi: Fix AGESA heap deallocator
......................................................................

soc/amd/common/block/pi: Fix AGESA heap deallocator

The deallocation was always subtracting the header, even when it
shouldn't. This caused problems for the allocator where buffer
sizes were incorrect and freed and used buffers could collide.
Fix the deallocation size.

Clear deallocated concatinated buffer header memory.

Fix the initial calculation of the total buffer size
available to be allocated.

BUG=b:71764350
TEST= Boot grunt.
BRANCH=none

Change-Id: I2789ddf72d662f24709dc5d9873741169cc4ef36
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/soc/amd/common/block/pi/heapmanager.c
1 file changed, 21 insertions(+), 18 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/23284/2
-- 
To view, visit https://review.coreboot.org/23284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2789ddf72d662f24709dc5d9873741169cc4ef36
Gerrit-Change-Number: 23284
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180116/914c51d4/attachment.html>


More information about the coreboot-gerrit mailing list