[coreboot-gerrit] Change in coreboot[master]: util/genbuild_h: Add gitfile support

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/23256 )

Change subject: util/genbuild_h: Add gitfile support
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/23256/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23256/1//COMMIT_MSG@10
PS1, Line 10: wheter
whether


https://review.coreboot.org/#/c/23256/1/util/genbuild_h/genbuild_h.sh
File util/genbuild_h/genbuild_h.sh:

https://review.coreboot.org/#/c/23256/1/util/genbuild_h/genbuild_h.sh@32
PS1, Line 32: z	
> oops, a tab
Really we only care that we're inside a git repo.  Maybe:

 elif git rev-parse --show-cdup >/dev/null 2>&1; then



-- 
To view, visit https://review.coreboot.org/23256
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bb13d607a01f4f28fa8b165769e0a1f702da362
Gerrit-Change-Number: 23256
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 15 Jan 2018 19:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180115/5963914d/attachment.html>