[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Remove IccMax settings from DT

Gaggery Tsai (Code Review) gerrit at coreboot.org
Mon Jan 15 16:31:05 CET 2018


Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/23278


Change subject: mb/google/fizz: Remove IccMax settings from DT
......................................................................

mb/google/fizz: Remove IccMax settings from DT

This patch removes IccMax settings from device tree since they
are handled in SoC code from patch e1a75d.

BUG=b:71369428
BRANCH=None
TEST="USE=fw_debug emerge-fizz chromeos-mrc coreboot
     chromeos-bootimage" & ensure the IccMax settings passed
     to FSP are from SoC code.

Change-Id: I6b01c50a2589d1722c5bf4aa2f44a9574df818f4
Signed-off-by: Gaggery Tsai <gaggery.tsai at intel.com>
---
M src/mainboard/google/fizz/devicetree.cb
1 file changed, 1 insertion(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/23278/1

diff --git a/src/mainboard/google/fizz/devicetree.cb b/src/mainboard/google/fizz/devicetree.cb
index 0af7603..a203976 100644
--- a/src/mainboard/google/fizz/devicetree.cb
+++ b/src/mainboard/google/fizz/devicetree.cb
@@ -117,6 +117,7 @@
 	#| IccMax         | 7A    | 34A   | 35A   | 35A   |
 	#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
 	#+----------------+-------+-------+-------+-------+
+	#Note: IccMax settings are moved to SoC code 
 	register "domain_vr_config[VR_SYSTEM_AGENT]" = "{
 		.vr_config_enable = 1,
 		.psi1threshold = VR_CFG_AMP(20),
@@ -126,7 +127,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(7),
 		.voltage_limit = 1520,
 	}"
 
@@ -139,7 +139,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(34),
 		.voltage_limit = 1520,
 	}"
 
@@ -152,7 +151,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(35),
 		.voltage_limit = 1520,
 	}"
 
@@ -165,7 +163,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(35),
 		.voltage_limit = 1520,
 	}"
 

-- 
To view, visit https://review.coreboot.org/23278
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b01c50a2589d1722c5bf4aa2f44a9574df818f4
Gerrit-Change-Number: 23278
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180115/c6a3f737/attachment.html>


More information about the coreboot-gerrit mailing list