[coreboot-gerrit] Change in coreboot[master]: security/tpm: Implement hashing function in TSS

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22735 )

Change subject: security/tpm: Implement hashing function in TSS
......................................................................


Patch Set 11:

(12 comments)

https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c
File src/security/tpm/tss/tcg-1.2/tss.c:

https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@353
PS10, Line 353: 	struct s_tpm_sha1_start_cmd cmd = tpm_sha1_start_cmd;
> struct s_tpm_sha1_start_cmd cmd = tpm_sha1_start_cmd;
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@357
PS10, Line 357: 	result = tlcl_send_receive(cmd.buffer, response, sizeof(response));
> obsolete with initialization on top
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@370
PS10, Line 370: 	struct s_tpm_sha1_update_cmd cmd = tpm_sha1_update_cmd;
> const
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@372
PS10, Line 372: 	uint32_t total_length;
> struct s_tpm_sha1_update_cmd cmd = tpm_sha1_update_cmd;
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@374
PS10, Line 374: 	total_length =
> uint32_t
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@378
PS10, Line 378: 
> obsolete with initialization on top
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@388
PS10, Line 388: 	struct s_tpm_sha1_complete_cmd cmd = tpm_sha1_complete_cmd;
> const
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@389
PS10, Line 389: 	uint8_t response[TPM_LARGE_ENOUGH_COMMAND_SIZE];
> uint8_t *digest is sufficient here
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@391
PS10, Line 391: 	uint32_t result;
> struct s_tpm_sha1_complete_cmd cmd = tpm_sha1_complete_cmd;
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@393
PS10, Line 393: 	total_length =
> uint32_t
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@398
PS10, Line 398: 	to_tpm_uint32(cmd.buffer + tpm_sha1_complete_cmd.length,
> obsolete with initialization on top
Done


https://review.coreboot.org/#/c/22735/10/src/security/tpm/tss/tcg-1.2/tss.c@400
PS10, Line 400: 	memcpy(cmd.buffer + tpm_sha1_complete_cmd.data, message,
> no sure what the next to lines are good for...
buffer size is different so the tpm command buffer is dynamically aligned.



-- 
To view, visit https://review.coreboot.org/22735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib84513e8cbfe1ef11f495b873de0331178915c59
Gerrit-Change-Number: 22735
Gerrit-PatchSet: 11
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 15 Jan 2018 15:15:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180115/18adbdd4/attachment.html>