[coreboot-gerrit] Change in coreboot[master]: security/tpm: Set up generic TSPI

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22106 )

Change subject: security/tpm: Set up generic TSPI
......................................................................


Patch Set 34:

(6 comments)

https://review.coreboot.org/#/c/22106/32/src/security/tpm/tspi/tspi.c
File src/security/tpm/tspi/tspi.c:

https://review.coreboot.org/#/c/22106/32/src/security/tpm/tspi/tspi.c@76
PS32, Line 76: 		 * It is possible that the TPM was delivered with the physical
> overlength
Done


https://review.coreboot.org/#/c/22106/32/src/security/tpm/tspi/tspi.c@82
PS32, Line 82: 			printk(
> overlength
Done


https://review.coreboot.org/#/c/22106/32/src/security/tpm/tspi/tspi.c@88
PS32, Line 88: 		result = tlcl_assert_physical_presence();
> overlength
Done


https://review.coreboot.org/#/c/22106/32/src/security/tpm/tspi/tspi.c@101
PS32, Line 101: 	}
> overlength
Done


https://review.coreboot.org/#/c/22106/32/src/security/tpm/tspi/tspi.c@116
PS32, Line 116: 		else
> overlength
Done


https://review.coreboot.org/#/c/22106/32/src/security/tpm/tspi/tspi.c@130
PS32, Line 130: 	    result != TPM_SUCCESS) {
> why call call __tpm_setup here ? Just move the whole code to tpm_setup.
Done



-- 
To view, visit https://review.coreboot.org/22106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb
Gerrit-Change-Number: 22106
Gerrit-PatchSet: 34
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Randall Spangler <randall at spanglers.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 15 Jan 2018 15:01:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180115/a2aba538/attachment.html>