[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add two weak methods for vboot2

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22102 )

Change subject: security/vboot: Add two weak methods for vboot2
......................................................................


Patch Set 11:

(2 comments)

https://review.coreboot.org/#/c/22102/10/src/security/vboot/bootmode.c
File src/security/vboot/bootmode.c:

https://review.coreboot.org/#/c/22102/10/src/security/vboot/bootmode.c@173
PS10, Line 173: #if IS_ENABLED(CONFIG_VBOOT_NO_BOARD_SUPPORT)
> Not sure about the name... […]
Done


https://review.coreboot.org/#/c/22102/10/src/security/vboot/bootmode.c@176
PS10, Line 176:  * get_recovery_mode_switch should be implemented as default function.
> Not sure what this means. Recovery mode switch doesn't really have anything to do with VBNV.
Done



-- 
To view, visit https://review.coreboot.org/22102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b1555bd93e1605e04d5c3ea6a752eb1459e426e
Gerrit-Change-Number: 22102
Gerrit-PatchSet: 11
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Randall Spangler <randall at spanglers.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 15 Jan 2018 14:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180115/575fd0e6/attachment.html>