[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Remove iccmax setting from devicetree

Furquan Shaikh (Code Review) gerrit at coreboot.org
Mon Jan 15 04:35:23 CET 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23265


Change subject: mb/google/poppy/variants/nami: Remove iccmax setting from devicetree
......................................................................

mb/google/poppy/variants/nami: Remove iccmax setting from devicetree

Change e1a75d4(soc/intel/skylake: Override KBL IccMax settings)
provides correct iccmax settings for kbl-u based on the SKU. Thus,
there is no need to override these values in devicetree. This change
gets rid of iccmax settings in the nami devicetree.

Change-Id: Ie7220bae71fcc597fc20c5e98793d4ea7af5650e
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/nami/devicetree.cb
1 file changed, 0 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/23265/1

diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb
index 5e23d45..6c352db 100644
--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb
@@ -79,7 +79,6 @@
 	#| Psi4Enable     | 1     | 1     | 1     | 1     |
 	#| ImonSlope      | 0     | 0     | 0     | 0     |
 	#| ImonOffset     | 0     | 0     | 0     | 0     |
-	#| IccMax         | 5A    | 24A   | 24A   | 24A   |
 	#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
 	#| AcLoadline     | 15    | 5.7   | 5.5   | 5.5   |
 	#| DcLoadline     | 14.3  | 4.83  | 4.2   | 4.2   |
@@ -93,7 +92,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(5),
 		.voltage_limit = 1520,
 		.ac_loadline = 1500,
 		.dc_loadline = 1430,
@@ -108,7 +106,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(24),
 		.voltage_limit = 1520,
 		.ac_loadline = 570,
 		.dc_loadline = 483,
@@ -123,7 +120,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(24),
 		.voltage_limit = 1520,
 		.ac_loadline = 550,
 		.dc_loadline = 420,
@@ -138,7 +134,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(24),
 		.voltage_limit = 1520,
 		.ac_loadline = 550,
 		.dc_loadline = 420,

-- 
To view, visit https://review.coreboot.org/23265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7220bae71fcc597fc20c5e98793d4ea7af5650e
Gerrit-Change-Number: 23265
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180115/b5c3e8e1/attachment-0001.html>


More information about the coreboot-gerrit mailing list