[coreboot-gerrit] Change in coreboot[master]: mainboard/glkrvp: Ignore DMIC_DATA pin IOSSTATE

Srinidhi N Kaushik (Code Review) gerrit at coreboot.org
Sat Jan 13 01:14:40 CET 2018


Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/23246 )

Change subject: mainboard/glkrvp: Ignore DMIC_DATA pin IOSSTATE
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/23246/3/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c
File src/mainboard/intel/glkrvp/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/23246/3/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c@211
PS3, Line 211: S_M_DATA_1*
> This is a DATA pin. So:  AVS_M_DATA_1 is right.
Done



-- 
To view, visit https://review.coreboot.org/23246
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bf403564e927deb8fed7f415e334bb230107cb0
Gerrit-Change-Number: 23246
Gerrit-PatchSet: 4
Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 13 Jan 2018 00:14:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180113/8fbd24b1/attachment.html>


More information about the coreboot-gerrit mailing list