[coreboot-gerrit] Change in coreboot[master]: drivers/gpio_keys: Add driver for handling gpio-keys

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Jan 12 05:36:29 CET 2018


Hello shkim, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/23236

to look at the new patch set (#3).

Change subject: drivers/gpio_keys: Add driver for handling gpio-keys
......................................................................

drivers/gpio_keys: Add driver for handling gpio-keys

This change adds the required device node in SSDT for defining
gpio-keys. Currently, it supports only one gpio-key per device
node.

TEST=Verified by adding details to devicetree that device node is
added to SSDT:
        Device (PENH)
        {
            Name (_HID, "PRP0001")  // _HID: Hardware ID
            Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
            {
                GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionInputOnly,
                    "\\_SB.PCI0.GPIO", 0x00, ResourceConsumer, ,
                    )
                    {   // Pin list
                        0x0024
                    }
            })
            Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
            {
                ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                Package (0x01)
                {
                    Package (0x02)
                    {
                        "compatible",
                        "gpio-keys"
                    }
                }
            })
            Device (EJCT)
            {
                Name (_HID, "PRP0001")  // _HID: Hardware ID
                Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                {
                    ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                    Package (0x04)
                    {
                        Package (0x02)
                        {
                            "linux,code",
                            0x0F
                        },

                        Package (0x02)
                        {
                            "linux,input-type",
                            0x05
                        },

                        Package (0x02)
                        {
                            "label",
                            "pen_eject"
                        },

                        Package (0x02)
                        {
                            "gpios",
                            Package (0x04)
                            {
                                \_SB.PCI0.I2C0.PENH,
                                Zero,
                                Zero,
                                One
                            }
                        }
                    }
                })
            }
        }

Change-Id: I6f11397b17d9de1c87d56f6a61669ef4052ec27b
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
A src/drivers/generic/gpio_keys/Kconfig
A src/drivers/generic/gpio_keys/Makefile.inc
A src/drivers/generic/gpio_keys/chip.h
A src/drivers/generic/gpio_keys/gpio_keys.c
4 files changed, 182 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/23236/3
-- 
To view, visit https://review.coreboot.org/23236
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f11397b17d9de1c87d56f6a61669ef4052ec27b
Gerrit-Change-Number: 23236
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: shkim <sh_.kim at samsung.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180112/f262b521/attachment.html>


More information about the coreboot-gerrit mailing list