[coreboot-gerrit] Change in coreboot[master]: mainboard/google/zoombini: add EC to ACPI tables

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/23237 )

Change subject: mainboard/google/zoombini: add EC to ACPI tables
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/23237/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23237/1//COMMIT_MSG@9
PS1, Line 9: this adds some missing ACPI entries for the EC and CPU.
and power button.


https://review.coreboot.org/#/c/23237/1/src/mainboard/google/zoombini/dsdt.asl
File src/mainboard/google/zoombini/dsdt.asl:

https://review.coreboot.org/#/c/23237/1/src/mainboard/google/zoombini/dsdt.asl@18
PS1, Line 18: baseboard
variant


https://review.coreboot.org/#/c/23237/1/src/mainboard/google/zoombini/dsdt.asl@19
PS1, Line 19: baseboard
variant


https://review.coreboot.org/#/c/23237/1/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h
File src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h:

https://review.coreboot.org/#/c/23237/1/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h@35
PS1, Line 35: GPE0_LAN_WAK
Please mention in the commit message that the EC wake pin is corrected.



-- 
To view, visit https://review.coreboot.org/23237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d091bdf25f9a806bd36329d1f17ac34b3115e48
Gerrit-Change-Number: 23237
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
Gerrit-Comment-Date: Fri, 12 Jan 2018 04:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180112/77e7371b/attachment.html>