[coreboot-gerrit] Change in coreboot[master]: google/kahlee/acpi: populate kahlee and grunt audio codec .asl as var...

Daniel Kurtz (Code Review) gerrit at coreboot.org
Fri Jan 12 04:01:38 CET 2018


Hello Daniel Kurtz, build bot (Jenkins), Marc Jones, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/23234

to look at the new patch set (#2).

Change subject: google/kahlee/acpi: populate kahlee and grunt audio codec .asl as variants
......................................................................

google/kahlee/acpi: populate kahlee and grunt audio codec .asl as variants

Grunt and Kahlee have different audio codecs.
Describe them in separate .asl variant files.

Since grunt is the 'baseboard', put its configuration under baseboard, and
#include it from the grunt variant.

BUG=b:71772141
TEST=Boot kahlee to kernel, audio works.
TEST=Boot grunt to kernel, no messages like:
  i2c_designware AMD0010:00: controller timed out

Change-Id: I0d1407286ff8d8ba2f533b6bc7b323d38cdf6b23
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/mainboard/google/kahlee/acpi/mainboard.asl
A src/mainboard/google/kahlee/variants/baseboard/include/baseboard/audio.asl
A src/mainboard/google/kahlee/variants/grunt/include/variant/audio.asl
A src/mainboard/google/kahlee/variants/kahlee/include/variant/audio.asl
4 files changed, 141 insertions(+), 41 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/23234/2
-- 
To view, visit https://review.coreboot.org/23234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0d1407286ff8d8ba2f533b6bc7b323d38cdf6b23
Gerrit-Change-Number: 23234
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180112/442e7779/attachment.html>


More information about the coreboot-gerrit mailing list