[coreboot-gerrit] Change in coreboot[master]: soc/amd/stonyridge: Give I2C devices unique _UIDs

[Daniel Kurtz (Code Review)]

Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23233

to review the following change.


Change subject: soc/amd/stonyridge: Give I2C devices unique _UIDs
......................................................................

soc/amd/stonyridge: Give I2C devices unique _UIDs

The ACPI unique identifier (_UID) should be unique.
This doesn't actually matter much for Linux, though, since the kernel
can handle it when the BIOS doesn't get this right:

See:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4b6cae2f36d92b31788f10816709d5290a1119a
 b4b6cae2f36d ACPI / platform: use ACPI device name instead of _HID._UID

Change-Id: I8b1b3143174584a93f3d45bf482b8922b3f0ec12
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/soc/amd/stoneyridge/acpi/sb_fch.asl
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/23233/1

diff --git a/src/soc/amd/stoneyridge/acpi/sb_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_fch.asl
index 9bf7dec..2ffd951 100644
--- a/src/soc/amd/stoneyridge/acpi/sb_fch.asl
+++ b/src/soc/amd/stoneyridge/acpi/sb_fch.asl
@@ -111,7 +111,7 @@
 
 Device (I2CC) {
 	Name (_HID, "AMD0010")
-	Name (_UID, 0x0)
+	Name (_UID, 0x2)
 	Name (_CRS, ResourceTemplate()
 	{
 		IRQ (Edge, ActiveHigh, Exclusive) { 6 }
@@ -127,7 +127,7 @@
 Device (I2CD)
 {
 	Name (_HID, "AMD0010")
-	Name (_UID, 0x1)
+	Name (_UID, 0x3)
 	Name (_CRS, ResourceTemplate() {
 		IRQ (Edge, ActiveHigh, Exclusive) { 14 }
 		Memory32Fixed(ReadWrite, 0xFEDC5000, 0x1000)

-- 
To view, visit https://review.coreboot.org/23233
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b1b3143174584a93f3d45bf482b8922b3f0ec12
Gerrit-Change-Number: 23233
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180112/17ab3d29/attachment-0001.html>