[coreboot-gerrit] Change in coreboot[master]: google/kahlee/grunt: Add Grunt codec ASL

[Marc Jones (Code Review)]

Hello Akshu Agrawal,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23226

to review the following change.


Change subject: google/kahlee/grunt: Add Grunt codec ASL
......................................................................

google/kahlee/grunt: Add Grunt codec ASL

Add the codec ACPI tables for Grunt.
Note, we can't use the generic drivers due to the PCI scope
expectation. The AMD I2C are not PCI devices.

BUG=b:69397774
TEST=Codec driver loads. Check dmesg.

Change-Id: I1cc245357d1f3d444e5a5012466eaa5d75d637eb
Signed-off-by: Akshu Agrawal <akshu.agrawal at amd.com>
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/mainboard/google/kahlee/acpi/mainboard.asl
1 file changed, 100 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/23226/1

diff --git a/src/mainboard/google/kahlee/acpi/mainboard.asl b/src/mainboard/google/kahlee/acpi/mainboard.asl
index 30b7ade..354c9a6 100644
--- a/src/mainboard/google/kahlee/acpi/mainboard.asl
+++ b/src/mainboard/google/kahlee/acpi/mainboard.asl
@@ -96,3 +96,103 @@
 		Return (0xF)
 	}
 }
+
+#if IS_ENABLED(CONFIG_BOARD_GOOGLE_KAHLEE)
+/* Realtek Audio Codec */
+Device (RTEK)   /* Audio Codec driver I2CS*/
+{
+	Name (_ADR, 0)
+	Name (_HID, "10EC5650")
+	Name (_CID, "10EC5650")
+	Name (_DDN, "RTEK Codec Controller ")
+	Name (_UID, 1)
+
+	Device (I2S) /* I2S machine driver for RT5650 */
+	{
+		Name (_ADR, 1)
+		Name (_HID, "AMDI1002")
+		Name (_CID, "AMDI1002")
+	}
+
+	Method (_CRS, 0x0, Serialized)
+	{
+		Name (SBUF, ResourceTemplate ()
+		{
+			I2CSerialBus(
+			0x1A,   /* SlaveAddress: bus address */
+			ControllerInitiated,    /* SlaveMode: default to ControllerInitiated */
+			400000,                 /* ConnectionSpeed: in Hz */
+			AddressingMode7Bit,     /* Addressing Mode: default to 7 bit */
+			"\\_SB.I2CA",           /* ResourceSource: I2C bus controller name */
+			)
+
+			/* Jack Detect AGPIO90 */
+			GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+				"\\_SB.GPIO") { 90 }
+		})
+		Return (SBUF)
+	}
+
+	Method (_STA)
+	{
+		Return (0xF)
+	}
+}
+#endif /* IS_ENABLED(CONFIG_BOARD_GOOGLE_KAHLEE) */
+
+#if IS_ENABLED(CONFIG_BOARD_GOOGLE_GRUNT)
+/* DA7219 codec */
+Device (DIAL)  /* audio codec*/
+{
+	Name (_ADR, 0)
+	Name (_HID, "DLGS7219")
+	Name (_CID, "DLGS7219")
+	Name (_DDN, "DA7219 Codec Controller ")
+	Name (_UID, 1)
+
+	Device (I2S) /* I2S machine driver for RT5650 */
+	{
+		Name (_ADR, 1)
+		Name (_HID, "AMDI7219")
+		Name (_CID, "AMDI7219")
+	}
+
+	Method (_CRS, 0x0, Serialized)
+	{
+		Name (SBUF, ResourceTemplate ()
+		{
+			I2CSerialBus(
+			0x1A,   /* SlaveAddress: bus address */
+			ControllerInitiated,    /* SlaveMode: default to ControllerInitiated */
+			400000,                 /* ConnectionSpeed: in Hz */
+			AddressingMode7Bit,     /* Addressing Mode: default to 7 bit */
+			"\\_SB.I2CA",           /* ResourceSource: I2C bus controller name */
+			)
+
+			/* Jack Detect AGPIO14 */
+			GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+				"\\_SB.GPIO") { 14 }
+		})
+		Return (SBUF)
+	}
+
+	Method (_STA)
+	{
+		Return (0xF)
+	}
+}
+
+/* MAX98357 codec */
+Device (MAXA)
+{
+	Name (_ADR, 0)
+	Name (_HID, "MX98357A")
+	Name (_CID, "MX98357A")
+	Name (_DDN, "MX98357A Codec Controller ")
+	Name (_UID, 1)
+
+	Method (_STA, 0x0, NotSerialized) {
+			Return (0x0F)
+	}
+}
+#endif /* IS_ENABLED(CONFIG_BOARD_GOOGLE_GRUNT) */

-- 
To view, visit https://review.coreboot.org/23226
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cc245357d1f3d444e5a5012466eaa5d75d637eb
Gerrit-Change-Number: 23226
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal at amd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180111/63113201/attachment.html>