[coreboot-gerrit] Change in coreboot[master]: GLK: Klockwork fix for #27773

[Shaunak Saha (Code Review)]

Hello Ravishankar Sarawadi,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23223

to review the following change.


Change subject: GLK: Klockwork fix for #27773
......................................................................

GLK: Klockwork fix for #27773

Change-Id: Ie34931504ad92739fdaa68ec7989e76e8eee2595
Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi at intel.com>
---
M src/soc/intel/apollolake/meminit_util_glk.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/23223/1

diff --git a/src/soc/intel/apollolake/meminit_util_glk.c b/src/soc/intel/apollolake/meminit_util_glk.c
index 2ef2e49..20e7cd2 100644
--- a/src/soc/intel/apollolake/meminit_util_glk.c
+++ b/src/soc/intel/apollolake/meminit_util_glk.c
@@ -39,6 +39,10 @@
 	}
 
 	memory_info_hob = fsp_find_smbios_memory_info(&hob_size);
+	if (memory_info_hob == NULL) {
+		printk(BIOS_ERR, "SMBIOS memory info HOB is missing\n");
+		return;
+	}
 
 	/*
 	 * Allocate CBMEM area for DIMM information used to populate SMBIOS

-- 
To view, visit https://review.coreboot.org/23223
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie34931504ad92739fdaa68ec7989e76e8eee2595
Gerrit-Change-Number: 23223
Gerrit-PatchSet: 1
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180111/76136933/attachment.html>