[coreboot-gerrit] Change in coreboot[master]: security/tpm: Add TPM measurement code

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22867 )

Change subject: security/tpm: Add TPM measurement code
......................................................................


Patch Set 4:

(7 comments)

https://review.coreboot.org/#/c/22867/4/src/security/tpm/tspi.h
File src/security/tpm/tspi.h:

https://review.coreboot.org/#/c/22867/4/src/security/tpm/tspi.h@50
PS4, Line 50: #endif /* TSPI_H_ */
> Is the line ending correct. It looks strange in Gerrit.
?


https://review.coreboot.org/#/c/22867/4/src/security/tpm/tspi/tspi.c
File src/security/tpm/tspi/tspi.c:

https://review.coreboot.org/#/c/22867/4/src/security/tpm/tspi/tspi.c@198
PS4, Line 198: 		printk(BIOS_ERR, "TPM: Start hash routine.\n");
> This error message is not clear.
Done


https://review.coreboot.org/#/c/22867/4/src/security/tpm/tspi/tspi.c@221
PS4, Line 221: 		printk(BIOS_ERR, "TPM: Complete hash routine.\n");
> The message is not clear to me. The failure should be better formulated.
Done


https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss.h
File src/security/tpm/tss.h:

https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss.h@185
PS4, Line 185:  * TCPA ACPI log
> Please elaborate.
Done


https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss.c
File src/security/tpm/tss/tcg-1.2/tss.c:

https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss.c@489
PS4, Line 489: 	*ptr += 1;
> you are incrementing the entry counter twice in case the cbmem entry already exists. […]
Done


https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss_structures.h
File src/security/tpm/tss/tcg-1.2/tss_structures.h:

https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss_structures.h@107
PS4, Line 107: 	
> Space instead of tab please.
Done


https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss_structures.h@111
PS4, Line 111: 	TSS_PCRINDEX PCRIndex; //PCRIndex event extended to
> Please add a space after the comment lines.
Done



-- 
To view, visit https://review.coreboot.org/22867
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a52494f647d21e2587231af26ed13d62b3a72f5
Gerrit-Change-Number: 22867
Gerrit-PatchSet: 4
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 11 Jan 2018 15:20:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180111/1916abd1/attachment.html>