[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Remove digitizer reset control from ACPI

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23212


Change subject: mb/google/poppy: Remove digitizer reset control from ACPI
......................................................................

mb/google/poppy: Remove digitizer reset control from ACPI

Digitizer power is not controlled by SoC. Also, since the digitizer
uses I2C-HID driver in Linux kernel, the device is put into sleep
anytime system is suspended. Thus, there is no need to control the
reset gpio using ACPI power resource.

TEST=Verified that digitizer device is properly detected on boot-up
and after suspend/resume.

Change-Id: Id11b8412d0ac48b2701d53b0a22ad3b747b544ec
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/baseboard/devicetree.cb
M src/mainboard/google/poppy/variants/baseboard/gpio.c
2 files changed, 1 insertion(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/23212/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
index aaf6ea2..89dc22a 100644
--- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
@@ -311,10 +311,6 @@
 				register "generic.desc" = ""WCOM Digitizer""
 				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D1_IRQ)"
 				register "generic.wake" = "GPE0_DW1_12"
-				register "generic.has_power_resource" = "1"
-				register "generic.disable_gpio_export_in_crs" = "1"
-				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D3)"
-				register "generic.reset_delay_ms" = "1"
 				register "hid_desc_reg_offset" = "0x1"
 				device i2c 0x9 on end
 			end
diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c
index 8b9a21b..1290d18 100644
--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c
+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c
@@ -167,7 +167,7 @@
 	/* D2  : SPI1_MISO ==> PEN_PDCT_L */
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_D2, NONE, DEEP),
 	/* D3  : SPI1_MOSI ==> PEN_RST_L */
-	PAD_CFG_GPO(GPP_D3, 0, DEEP),
+	PAD_CFG_GPO(GPP_D3, 1, DEEP),
 	/* D4  : FASHTRIG ==> LTE_GPS_OFF_ODL */
 	PAD_CFG_GPO(GPP_D4, 1, DEEP),
 	/* D5  : ISH_I2C0_SDA ==> ISH_I2C_SENSOR_1V8_SDA */

-- 
To view, visit https://review.coreboot.org/23212
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id11b8412d0ac48b2701d53b0a22ad3b747b544ec
Gerrit-Change-Number: 23212
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180111/7a3d2d7e/attachment.html>