[coreboot-gerrit] Change in coreboot[master]: mainboard/google/zoombini: add gpio init to ramstage
Nick Vaccaro (Code Review)
gerrit at coreboot.org
Tue Jan 9 23:41:33 CET 2018
Hello Nick Vaccaro,
I'd like you to do a code review. Please visit
https://review.coreboot.org/23194
to review the following change.
Change subject: mainboard/google/zoombini: add gpio init to ramstage
......................................................................
mainboard/google/zoombini: add gpio init to ramstage
-add initialization of gpio table to mainboard_silicon_init_params()
-fix input parameter type for mainboard_silicon_init_params() for
FSP2_0.
BUG=b:69011806
BRANCH=chromeos-2016.05
TEST=none
Change-Id: If8cba786a127a8704eb240380841362e3eb06552
Signed-off-by: Nick Vaccaro <nvaccaro at chromium.org>
---
M src/mainboard/google/zoombini/ramstage.c
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/23194/1
diff --git a/src/mainboard/google/zoombini/ramstage.c b/src/mainboard/google/zoombini/ramstage.c
index ffbf6fe..7c73357 100644
--- a/src/mainboard/google/zoombini/ramstage.c
+++ b/src/mainboard/google/zoombini/ramstage.c
@@ -13,10 +13,15 @@
* GNU General Public License for more details.
*/
+#include <baseboard/variants.h>
#include <soc/ramstage.h>
#include <variant/gpio.h>
-void mainboard_silicon_init_params(FSP_SIL_UPD *params)
+void mainboard_silicon_init_params(FSP_S_CONFIG *params)
{
- gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table));
+ size_t num;
+ const struct pad_config *gpio_table;
+
+ gpio_table = variant_gpio_table(&num);
+ gpio_configure_pads(gpio_table, num);
}
--
To view, visit https://review.coreboot.org/23194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8cba786a127a8704eb240380841362e3eb06552
Gerrit-Change-Number: 23194
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180109/0b057a22/attachment-0001.html>
More information about the coreboot-gerrit
mailing list