[coreboot-gerrit] Change in coreboot[master]: mainboard/google/zoombini: move gpio.c out of baseboard
Nick Vaccaro (Code Review)
gerrit at coreboot.org
Tue Jan 9 23:41:32 CET 2018
Hello Nick Vaccaro,
I'd like you to do a code review. Please visit
https://review.coreboot.org/23192
to review the following change.
Change subject: mainboard/google/zoombini: move gpio.c out of baseboard
......................................................................
mainboard/google/zoombini: move gpio.c out of baseboard
Move gpio.c from variants/baseboard to mainboard/google/zoombini.
BUG=b:64395641
BRANCH=chromos-2016.05
TEST="emerge-zoombini coreboot" succeeds.
Change-Id: Idfc6c0a9c01d39d2e0b0fe7db61d00a11877067f
Signed-off-by: Nick Vaccaro <nvaccaro at chromium.org>
---
M src/mainboard/google/zoombini/Makefile.inc
R src/mainboard/google/zoombini/gpio.c
M src/mainboard/google/zoombini/variants/baseboard/Makefile.inc
3 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/23192/1
diff --git a/src/mainboard/google/zoombini/Makefile.inc b/src/mainboard/google/zoombini/Makefile.inc
index 10ba0eb0..57fb71c 100644
--- a/src/mainboard/google/zoombini/Makefile.inc
+++ b/src/mainboard/google/zoombini/Makefile.inc
@@ -15,6 +15,7 @@
bootblock-y += bootblock.c
bootblock-$(CONFIG_CHROMEOS) += chromeos.c
+bootblock-y += gpio.c
verstage-$(CONFIG_CHROMEOS) += chromeos.c
@@ -26,6 +27,7 @@
ramstage-y += boardid.c
ramstage-$(CONFIG_CHROMEOS) += chromeos.c
ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
+ramstage-y += gpio.c
ramstage-y += mainboard.c
smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
diff --git a/src/mainboard/google/zoombini/variants/baseboard/gpio.c b/src/mainboard/google/zoombini/gpio.c
similarity index 100%
rename from src/mainboard/google/zoombini/variants/baseboard/gpio.c
rename to src/mainboard/google/zoombini/gpio.c
diff --git a/src/mainboard/google/zoombini/variants/baseboard/Makefile.inc b/src/mainboard/google/zoombini/variants/baseboard/Makefile.inc
index 6caed38..1eb972c 100644
--- a/src/mainboard/google/zoombini/variants/baseboard/Makefile.inc
+++ b/src/mainboard/google/zoombini/variants/baseboard/Makefile.inc
@@ -13,9 +13,6 @@
## GNU General Public License for more details.
##
-bootblock-y += gpio.c
-
romstage-y += boardid.c
ramstage-y += boardid.c
-ramstage-y += gpio.c
--
To view, visit https://review.coreboot.org/23192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfc6c0a9c01d39d2e0b0fe7db61d00a11877067f
Gerrit-Change-Number: 23192
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180109/8672671b/attachment-0001.html>
More information about the coreboot-gerrit
mailing list