[coreboot-gerrit] Change in coreboot[master]: payloads: Add LinuxBoot payload in u-root mode

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/23071 )

Change subject: payloads: Add LinuxBoot payload in u-root mode
......................................................................


Patch Set 5:

(3 comments)

https://review.coreboot.org/#/c/23071/5/payloads/external/LinuxBoot/Kconfig
File payloads/external/LinuxBoot/Kconfig:

https://review.coreboot.org/#/c/23071/5/payloads/external/LinuxBoot/Kconfig@108
PS5, Line 108: 	string ""
> Empty prompt, huh? […]
otherwise kconfig complains


https://review.coreboot.org/#/c/23071/5/payloads/external/LinuxBoot/Makefile
File payloads/external/LinuxBoot/Makefile:

https://review.coreboot.org/#/c/23071/5/payloads/external/LinuxBoot/Makefile@31
PS5, Line 31: all: build initramfs
> Ew, isn't this cloning and (re)building u-root every time you run […]
Done


https://review.coreboot.org/#/c/23071/5/payloads/external/LinuxBoot/Makefile@40
PS5, Line 40: config: kernel
> Please use an actual file for the config target. Otherwise it  […]
Done



-- 
To view, visit https://review.coreboot.org/23071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a25ff6812e046acc688cbbb203cf262ad751659
Gerrit-Change-Number: 23071
Gerrit-PatchSet: 5
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 09 Jan 2018 13:49:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180109/4564ad1e/attachment.html>