[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Send SKU ID to EC

Gaggery Tsai (Code Review) gerrit at coreboot.org
Tue Jan 9 09:34:51 CET 2018


Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/23183


Change subject: mb/google/fizz: Send SKU ID to EC
......................................................................

mb/google/fizz: Send SKU ID to EC

This patch sends OEM and SKU ID to EC so that EC could use the
information to set correct fan table. The ID format is b0xxxyyyy
where xxx is 3 bits OEM ID and yyyy is 4 bits SKU ID.

BUG=b:70294260
BRANCH=None
TEST=emerge-fizz coreboot chromeos-bootimage & print SKU information
     from EC console to ensure EC receives the ID correctly.

Change-Id: I79527eae5d84cbfade02ad4d7b5d1d7c7868e499
Signed-off-by: Gaggery Tsai <gaggery.tsai at intel.com>
---
M src/mainboard/google/fizz/mainboard.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/23183/1

diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c
index 98c0078..ada5075 100644
--- a/src/mainboard/google/fizz/mainboard.c
+++ b/src/mainboard/google/fizz/mainboard.c
@@ -38,6 +38,7 @@
 #define GET_TYPEC_PL2(w)   (9 * (w) / 10)
 
 #define OEM_ID_COUNT	3
+#define OEM_ID_SHIFT	4
 #define SKU_ID_COUNT	7
 
 /* List of BJ adapters shipped with Fizz or its variants */
@@ -147,6 +148,9 @@
 static void mainboard_init(device_t dev)
 {
 	mainboard_ec_init();
+	/* Format b0xxxyyyy, where x is OEM ID and y is SKU ID */
+	google_chromeec_set_sku_id((board_oem_id() << OEM_ID_SHIFT) |
+								board_sku_id());
 }
 
 static unsigned long mainboard_write_acpi_tables(

-- 
To view, visit https://review.coreboot.org/23183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79527eae5d84cbfade02ad4d7b5d1d7c7868e499
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180109/1d5b452d/attachment.html>


More information about the coreboot-gerrit mailing list