[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x230: Implement ACPI methods to set battery thresholds for ...

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon Jan 8 22:30:42 CET 2018


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23175 )

Change subject: mb/lenovo/x230: Implement ACPI methods to set battery thresholds for x230
......................................................................


Patch Set 1: -Code-Review

(1 comment)

https://review.coreboot.org/#/c/23175/1/src/mainboard/lenovo/x230/acpi/bat_thresh.asl
File src/mainboard/lenovo/x230/acpi/bat_thresh.asl:

https://review.coreboot.org/#/c/23175/1/src/mainboard/lenovo/x230/acpi/bat_thresh.asl@25
PS1, Line 25:  
missing ','



-- 
To view, visit https://review.coreboot.org/23175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd6fe112635cd4b6fc12a6bbbb4f15f17d1d7cc
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Derlaft <derlafff at ya.ru>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 08 Jan 2018 21:30:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180108/df811f40/attachment.html>


More information about the coreboot-gerrit mailing list