[coreboot-gerrit] Change in libgfxinit[master]: gma pipe_setup: Write DSPSURF register last

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/23164


Change subject: gma pipe_setup: Write DSPSURF register last
......................................................................

gma pipe_setup: Write DSPSURF register last

The surface register arms the other plane registers for a synchronous
update and should be written last.

Change-Id: I723cdf7e319c62004d3c4db80959d8b14f553ff6
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M common/hw-gfx-gma-pipe_setup.adb
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/64/23164/1

diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb
index 08a4fa4..e417c5d 100644
--- a/common/hw-gfx-gma-pipe_setup.adb
+++ b/common/hw-gfx-gma-pipe_setup.adb
@@ -206,7 +206,6 @@
 
          Registers.Write
            (Controller.DSPSTRIDE, Word32 (Pixel_To_Bytes (FB.Stride, FB)));
-         Registers.Write (Controller.DSPSURF, FB.Offset and 16#ffff_f000#);
          if Config.Has_DSP_Linoff then
             Registers.Write (Controller.DSPLINOFF, 0);
          end if;
@@ -214,6 +213,7 @@
            (Register => Controller.DSPTILEOFF,
             Value    => Shift_Left (Word32 (FB.Start_Y), 16) or
                         Word32 (FB.Start_X));
+         Registers.Write (Controller.DSPSURF, FB.Offset and 16#ffff_f000#);
       end if;
    end Setup_Hires_Plane;
 

-- 
To view, visit https://review.coreboot.org/23164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I723cdf7e319c62004d3c4db80959d8b14f553ff6
Gerrit-Change-Number: 23164
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180108/9d83aa1e/attachment.html>