[coreboot-gerrit] Change in coreboot[master]: Nami: Fix DA7219 IRQ issue

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/23160 )

Change subject: Nami: Fix DA7219 IRQ issue
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/23160/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23160/1//COMMIT_MSG@7
PS1, Line 7: Nami
mb/google/nami: or mb/google/poppy/variants/nami:


https://review.coreboot.org/#/c/23160/1/src/mainboard/google/poppy/variants/nami/gpio.c
File src/mainboard/google/poppy/variants/nami/gpio.c:

https://review.coreboot.org/#/c/23160/1/src/mainboard/google/poppy/variants/nami/gpio.c@182
PS1, Line 182: 20K_PU
There is an external pull already present on this line. Do you still need an internal pull too?


https://review.coreboot.org/#/c/23160/1/src/mainboard/google/poppy/variants/nami/gpio.c@182
PS1, Line 182: DEEP
Why is this configured as DEEP as opposed to PLTRST for other APIC pins in this file?



-- 
To view, visit https://review.coreboot.org/23160
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6cff8325c4c7f02f6f4df547fde286e2ef83d5c
Gerrit-Change-Number: 23160
Gerrit-PatchSet: 1
Gerrit-Owner: Kaiyen Chang <kaiyen.chang at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 08 Jan 2018 09:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180108/42785788/attachment.html>