[coreboot-gerrit] Change in coreboot[master]: soc/rockchip/rk3399: Ensure correct init flow if edp_prepare fails

Ege Mihmanli (Code Review) gerrit at coreboot.org
Mon Jan 8 03:00:46 CET 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/23152

to look at the new patch set (#3).

Change subject: soc/rockchip/rk3399: Ensure correct init flow if edp_prepare fails
......................................................................

soc/rockchip/rk3399: Ensure correct init flow if edp_prepare fails

This patch fixes 2 edp display issues:
1. When rk_edp_prepare fails >3 times, edp_init isn't run because
while-condition is not satisfied. Then, only a partial init sequence is
ran. This causes all aux transactions to fail.
2. If rk_edp_prepare never succeeds, coreboot never leaves link training
stage due to infinite loop.

Change-Id: I44c3f53e8786558c43078d4afe9acde4d64796e7
Signed-off-by: Ege Mihmanli <egemih at google.com>
---
D 3rdparty/arm-trusted-firmware
D 3rdparty/blobs
D 3rdparty/chromeec
D 3rdparty/libgfxinit
D 3rdparty/libhwbase
D 3rdparty/vboot
M src/soc/rockchip/rk3399/display.c
7 files changed, 16 insertions(+), 13 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/23152/3
-- 
To view, visit https://review.coreboot.org/23152
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44c3f53e8786558c43078d4afe9acde4d64796e7
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 3
Gerrit-Owner: Ege Mihmanli <egemih at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180108/0b79be95/attachment.html>


More information about the coreboot-gerrit mailing list