[coreboot-gerrit] Change in coreboot[master]: cpu/intel/speedstep: Fix the PNOT ACPI method

Arthur Heymans (Code Review) gerrit at coreboot.org
Sat Jan 6 19:10:34 CET 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/23144

to look at the new patch set (#2).

Change subject: cpu/intel/speedstep: Fix the PNOT ACPI method
......................................................................

cpu/intel/speedstep: Fix the PNOT ACPI method

The PNOT method never notifies the CPU to update it's _CST methods due
to reliance on inexisting variable (PDCx).

Add a method in the speedstep ssdt generator to notify all available
CPU nodes and hook this up in this file.

The cpu.asl file is moved to cpu/intel/speedstep/acpi since it now
relies on code generated in the speedstep ssdt generator. CPUs not
using the speedstep code never included this PNOT method so this is
a logical place for this code to be.

Change-Id: Ie2ba5e07b401d6f7c80c31f2bfcd9ef3ac0c1ad1
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/arch/x86/include/arch/acpigen.h
M src/cpu/intel/speedstep/acpi.c
R src/cpu/intel/speedstep/acpi/cpu.asl
M src/mainboard/apple/macbook21/dsdt.asl
M src/mainboard/asus/p5gc-mx/dsdt.asl
M src/mainboard/getac/p470/dsdt.asl
M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl
M src/mainboard/ibase/mb899/dsdt.asl
M src/mainboard/intel/d510mo/dsdt.asl
M src/mainboard/intel/d945gclf/dsdt.asl
M src/mainboard/kontron/986lcd-m/dsdt.asl
M src/mainboard/lenovo/t400/dsdt.asl
M src/mainboard/lenovo/t60/dsdt.asl
M src/mainboard/lenovo/x200/dsdt.asl
M src/mainboard/lenovo/x60/dsdt.asl
M src/mainboard/roda/rk886ex/dsdt.asl
M src/mainboard/roda/rk9/dsdt.asl
17 files changed, 32 insertions(+), 37 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/23144/2
-- 
To view, visit https://review.coreboot.org/23144
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2ba5e07b401d6f7c80c31f2bfcd9ef3ac0c1ad1
Gerrit-Change-Number: 23144
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180106/04746153/attachment.html>


More information about the coreboot-gerrit mailing list