[coreboot-gerrit] Change in coreboot[master]: [RFC] Change the USE_BLOBS Kconfig name to DOWNLOAD_BLOBS

Nico Huber (Code Review) gerrit at coreboot.org
Sat Jan 6 16:19:47 CET 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/23142 )

Change subject: [RFC] Change the USE_BLOBS Kconfig name to DOWNLOAD_BLOBS
......................................................................


Patch Set 1:

>> What exactly is the broken assumption? Don't let broken Kconfigs/
>> Makefiles get into your way because somebody used dirty hacks to
>> get his code in.
> 
> Well for instance in soc/nvidia/tegra210 it is really used to use
> or not use a blob for memory controller training.

It's only used to hide a Kconfig option there. I'd just remove the
`depends on` line.


-- 
To view, visit https://review.coreboot.org/23142
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bc4821b376b07f0014f38b9a4aeda81de24732b
Gerrit-Change-Number: 23142
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 06 Jan 2018 15:19:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180106/713feaf4/attachment.html>


More information about the coreboot-gerrit mailing list