[coreboot-gerrit] Change in coreboot[master]: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES

[Hannah Williams (Code Review)]

Hannah Williams has uploaded this change for review. ( https://review.coreboot.org/23131


Change subject: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES
......................................................................

mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES

This patch adds the EC_GOOGLE_CHROMEEC_SWITCHES option so that we
use the common switch.c file

Change-Id: I93a2ba63015db17989c89ce1b5897de6a93e201f
Signed-off-by: Hannah Williams <hannah.williams at intel.com>
---
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/glkrvp/chromeos.c
2 files changed, 1 insertion(+), 27 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/23131/1

diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig
index 292da44..8c71e34 100644
--- a/src/mainboard/intel/glkrvp/Kconfig
+++ b/src/mainboard/intel/glkrvp/Kconfig
@@ -46,6 +46,7 @@
 config VBOOT
 	select HAS_RECOVERY_MRC_CACHE
 	select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
+	select EC_GOOGLE_CHROMEEC_SWITCHES
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/intel/glkrvp/chromeos.c b/src/mainboard/intel/glkrvp/chromeos.c
index b7f56ec..a87ce4a 100644
--- a/src/mainboard/intel/glkrvp/chromeos.c
+++ b/src/mainboard/intel/glkrvp/chromeos.c
@@ -35,39 +35,12 @@
 	lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
 }
 
-int get_lid_switch(void)
-{
-	if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))
-	/* Read lid switch state from the EC. */
-		return !!(google_chromeec_get_switches() & EC_SWITCH_LID_OPEN);
-	else
-		return 1;
-}
-
 int get_developer_mode_switch(void)
 {
 	/* No physical developer mode switch. It's virtual. */
 	return 0;
 }
 
-int get_recovery_mode_switch(void)
-{
-	if (!IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))
-		return 0;
-	/* Check if the EC has posted the keyboard recovery event. */
-	return !!(google_chromeec_get_events_b() &
-		  EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));
-}
-
-int clear_recovery_mode_switch(void)
-{
-	if (!IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))
-		return 0;
-	/* Clear keyboard recovery event. */
-	return google_chromeec_clear_events_b(
-		EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));
-}
-
 int get_write_protect_state(void)
 {
 	return 0;

-- 
To view, visit https://review.coreboot.org/23131
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93a2ba63015db17989c89ce1b5897de6a93e201f
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 1
Gerrit-Owner: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180105/78f8c247/attachment-0001.html>